(Nov-28-2023, 12:00 AM)rob101 Wrote: The #1 and most significant change you could make is to not have the passwords stored in the clear, rather store said as a sha256 hash value, which could be reversed when a user opens the app and enters a "master password". That aside, the code (from a very quick look) seems well written and your UI looks nice.

To add: maybe what I have in mind would not in fact work, but rather some encryption of the stored passwords would be the way to go. I'll have a think about it.

(Nov-28-2023, 12:24 AM)menator01 Wrote: You should not do wild card imports eg from tkinter import *. This will cause problems down the road.
Other than that, nicely done.

import tkinter as tk
import pandas as pd 
from datetime import date 
from random import sample
import math 
import os 

# Create path to executing directory
path = os.path.realpath(os.path.dirname(__file__))

class Data:
    '''
        Class will handle all data manipulations
    '''
    def __init__(self):
        pass 


class Window:
    ''' Class will handle all views '''
    def __init__(self, parent):
        parent.columnconfigure(0, weight=1)
        parent.rowconfigure(0, weight=1)
        parent.minsize(800,600)
        parent.resizable(False, False)

        container = tk.Frame(parent)
        container.grid(column=0, row=0, sticky='news')

        container.columnconfigure(0, weight=3)

        logo = tk.PhotoImage(file=f'{path}/resources/PasswordManager/logo.png')
        logo.backup = logo
        header = tk.Label(container)
        header['image'] = logo
        header.grid(column=0, row=0, padx=5, pady=0, sticky='new')

        btn_frame = tk.Frame(container)
        btn_frame.grid(column=0, row=1, sticky='new', padx=800/3, pady=5)
        btn_frame.grid_columnconfigure(0, weight=3, uniform='btn')
        btn_frame.grid_columnconfigure(1, weight=3, uniform='btn')

        self.display_btn = tk.Button(btn_frame, text='Display', cursor='hand2')
        self.display_btn['bg'] = 'red'
        self.display_btn['fg'] = 'white'
        self.display_btn.grid(column=0, row=0, sticky='new', padx=2, pady=2)
        self.display_btn.bind('<Enter>', lambda event: self.hover(self.display_btn))

        self.add_btn = tk.Button(btn_frame, text='Add', cursor='hand2')
        self.add_btn['bg'] = 'red'
        self.add_btn['fg'] = 'white'
        self.add_btn.grid(column=1, row=0, sticky='new', padx=4, pady=4)
        self.add_btn.bind('<Enter>', lambda event: self.hover(self.add_btn))

    def hover(self, btn):
        btn['activebackground'] = 'white'
        btn['activeforeground'] = 'red'



class Controller:
    def __init__(self, data, window):
        ''' Class will handle communications between Data and Window classes '''
        self.data = data 
        self.window = window


        # Button Commands
        self.window.display_btn['command'] = self.display
        self.window.add_btn['command'] = self.add 


    def display(self):
        print('display here')

    def add(self):
        print('Add data')


if __name__ == '__main__':
    root = tk.Tk()
    controller = Controller(Data(), Window(root))
    root.mainloop()

(Nov-28-2023, 11:14 PM)menator01 Wrote: I was intrigued by your project and started to take my own approach from your project. This will give you an example of how I was taught or advised how to do imports. I've only done the cover part. Buttons don't work yet.

import tkinter as tk
import pandas as pd 
from datetime import date 
from random import sample
import math 
import os 

# Create path to executing directory
path = os.path.realpath(os.path.dirname(__file__))

class Data:
    '''
        Class will handle all data manipulations
    '''
    def __init__(self):
        pass 


class Window:
    ''' Class will handle all views '''
    def __init__(self, parent):
        parent.columnconfigure(0, weight=1)
        parent.rowconfigure(0, weight=1)
        parent.minsize(800,600)
        parent.resizable(False, False)

        container = tk.Frame(parent)
        container.grid(column=0, row=0, sticky='news')

        container.columnconfigure(0, weight=3)

        logo = tk.PhotoImage(file=f'{path}/resources/PasswordManager/logo.png')
        logo.backup = logo
        header = tk.Label(container)
        header['image'] = logo
        header.grid(column=0, row=0, padx=5, pady=0, sticky='new')

        btn_frame = tk.Frame(container)
        btn_frame.grid(column=0, row=1, sticky='new', padx=800/3, pady=5)
        btn_frame.grid_columnconfigure(0, weight=3, uniform='btn')
        btn_frame.grid_columnconfigure(1, weight=3, uniform='btn')

        self.display_btn = tk.Button(btn_frame, text='Display', cursor='hand2')
        self.display_btn['bg'] = 'red'
        self.display_btn['fg'] = 'white'
        self.display_btn.grid(column=0, row=0, sticky='new', padx=2, pady=2)
        self.display_btn.bind('<Enter>', lambda event: self.hover(self.display_btn))

        self.add_btn = tk.Button(btn_frame, text='Add', cursor='hand2')
        self.add_btn['bg'] = 'red'
        self.add_btn['fg'] = 'white'
        self.add_btn.grid(column=1, row=0, sticky='new', padx=4, pady=4)
        self.add_btn.bind('<Enter>', lambda event: self.hover(self.add_btn))

    def hover(self, btn):
        btn['activebackground'] = 'white'
        btn['activeforeground'] = 'red'



class Controller:
    def __init__(self, data, window):
        ''' Class will handle communications between Data and Window classes '''
        self.data = data 
        self.window = window


        # Button Commands
        self.window.display_btn['command'] = self.display
        self.window.add_btn['command'] = self.add 


    def display(self):
        print('display here')

    def add(self):
        print('Add data')


if __name__ == '__main__':
    root = tk.Tk()
    controller = Controller(Data(), Window(root))
    root.mainloop()

(Nov-28-2023, 11:22 PM)rob101 Wrote: You're not wrong: hashing is a one way function.

What I had in mind would be over complicated for an app such as this.

I am not an expert in the use of encryption and many people who do put themselves in that category have made fundamental errors which have completely compromised the user data; the LastPass Data Breach possibly being the most high profile one in recent times.

I know your app is not being offered "as a service", but it's still worth keeping in mind just how difficult it is to get this kind of thing right and how easy it is to get it wrong.

I will again have a look at your app and feedback if I see anything that I think you should re-visit.

(Nov-28-2023, 11:41 PM)Sr999 Wrote: Again appreciate your time and I am
Waiting for your review
Thanks again