Review for my Fibonacci sequence, please. (´｡• ω •｡`)

Review for my Fibonacci sequence, please. (´｡• ω •｡`) - Printable Version

+- Python Forum (https://python-forum.io)
+-- Forum: General (https://python-forum.io/forum-1.html)
+--- Forum: Code Review (https://python-forum.io/forum-46.html)
+--- Thread: Review for my Fibonacci sequence, please. (´｡• ω •｡`) (/thread-40117.html)

Review for my Fibonacci sequence, please. (´｡• ω •｡`) - Carmazum - Jun-06-2023

Salutations, Pythonistas! python

I hope you are all well and that your families and friends are doing well. ヽ(・∀・)ﾉ

I have developed a simple piece of code that prints the Fibonacci sequence. I would like to get feedback on my novice coding skills from people more experienced than me. I applied things I have learned from courses, the official documentation and playing with the Python IDLE, ha, ha. Tongue

Before posting the code, I should clarify that the reason I avoided commenting on it was for two reasons:

I would like to know how self-explanatory my code is.
The truth is that I am terrible at it, ha, ha. Could you give me some advice, please?

That being said, now with you, the code:

def fibonacci(limit: int) -> 'Sequence in a List':
    n1, n2 = 0, 1
    accumulated: int = 0
    sequence: list = []
    while accumulated < limit:
        accumulated = n1 + n2
        n1 = n2
        n2 = accumulated
        sequence.append(accumulated)
    return sequence

while True:
    limit = input("Please, enter a limit for the sequence: ")
    try:
        print(fibonacci(int(limit)))
        break
    except ValueError:
        print(f"{limit} is not an integer.")

I'll stay tuned to the thread for any critiques, reviews, comments, etc. Thank you very much in advance, my friends! I hope your day is going well. ٩(｡•́‿•̀｡)۶

RE: Review for my Fibonacci sequence, please. (´｡• ω •｡`) - Gribouillis - Jun-06-2023

1) I think your code is quite self-explanatory, that's a good point.

2) The interaction loop could be written this way, so that the exception catches the exact conversion that we want to check

if __name__ == '__main__':
    while True:
        user_input = input("Please, enter a limit for the sequence: ")
        try:
            limit = int(user_input)
        except ValueError:
            print(f"{user_input!r} is not an integer.")
        else:
            break
    print(fibonacci(limit))

You could use multiple assignment to avoid a temporary variable

def fibonacci(limit: int) -> 'Sequence in a List':
    n1, n2 = 0, 1
    sequence: list = []
    while n2 < limit:
        n1, n2 = n2, n1 + n2
        sequence.append(n2)
    return sequence

Finally, here is an screwball version for you to study

from itertools import accumulate, chain, takewhile, tee

def fibonacci(limit: int) -> "Sequence in a list":
    def S():
        yield from _s
    s, _s = tee(accumulate(chain((1, 0), S())))
    return list(takewhile(limit.__ge__, s))

if __name__ == '__main__':
    while True:
        user_input = input("Please, enter a limit for the sequence: ")
        try:
            limit = int(user_input)
        except ValueError:
            print(f"{user_input!r} is not an integer.")
        else:
            break
    print(fibonacci(limit))

RE: Review for my Fibonacci sequence, please. (´｡• ω •｡`) - Larz60+ - Jun-06-2023

barebones, similar to w3 schools example:

>>> def fibseq(n): 
...     if n in (0,1):
...         return n
...     return fibseq(n-1) + fibseq(n-2)
... 
>>> print([fibseq(n) for n in range(12)])
[0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89]

RE: Review for my Fibonacci sequence, please. (´｡• ω •｡`) - Gribouillis - Jun-06-2023

(Jun-06-2023, 10:11 AM)Larz60+ Wrote: barebones:

Barbones, but an example of algorithmic antipattern. Improve this with @functools.lru_cache perhaps. Use dynamic programming.

RE: Review for my Fibonacci sequence, please. (´｡• ω •｡`) - Larz60+ - Jun-06-2023

Griboullis Wrote:Barbones, but an example of algorithmic antipattern. Improve this with @functools.lru_cache perhaps. Use dynamic programming.

From Python.org

from functools import lru_cache

@lru_cache(maxsize=None)
def fib(n):
    if n < 2:
        return n
    return fib(n-1) + fib(n-2)

print([fib(n) for n in range(16)])

Output:
[0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89, 144, 233, 377, 610]

RE: Review for my Fibonacci sequence, please. (´｡• ω •｡`) - ICanIBB - Jul-02-2023

There is one issue

RE: Review for my Fibonacci sequence, please. (´｡• ω •｡`) - codingismycraft - Nov-26-2023

Consider the complexity of your solution. How would you solve it in a more efficient way?